From 4653ae9f060ccdcfdacab1f311b544f7913228e0 Mon Sep 17 00:00:00 2001
From: zhenyan121 <3367366583@qq.com>
Date: Tue, 14 Jul 2026 21:19:56 +0800
Subject: [PATCH] refactor(ui/slider): improve track/thumb initialization and
 validation

Rename track/thumb accessors from set_track/set_thumb to get_track/get_thumb.
Add private init methods and a constant THUMB_WIDTH.
Add validation to set_width with log and assert.
Modify set_height to assume non-null m_thumb.
---
 include/Cubed/ui/slider.hpp | 11 +++++++----
 src/ui/slider.cpp           | 29 ++++++++++++++++++++---------
 2 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/include/Cubed/ui/slider.hpp b/include/Cubed/ui/slider.hpp
index b7ada89..825076e 100644
--- a/include/Cubed/ui/slider.hpp
+++ b/include/Cubed/ui/slider.hpp
@@ -10,15 +10,13 @@ public:
 
     Slider& set_slider(float* value, const float& min, const float& max);
 
-    Image& set_track();
-
-    Image& set_thumb();
+    Image& get_track();
+    Image& get_thumb();
 
     float width() const override;
     float height() const override;
 
     Slider& set_scale(float scale);
-
     Slider& set_width(float width);
     Slider& set_height(float h);
 
@@ -26,6 +24,11 @@ public:
     bool handle_mouse_button_event(const MouseButtonEvent& e) override;
 
 private:
+    static constexpr float THUMB_WIDTH = 5.0f;
+
+    void init_track();
+    void init_thumb();
+
     void update_value(float mouse_x);
 
     void on_update(float) override;
diff --git a/src/ui/slider.cpp b/src/ui/slider.cpp
index 419aca6..e92fa2d 100644
--- a/src/ui/slider.cpp
+++ b/src/ui/slider.cpp
@@ -6,7 +6,10 @@
 #include <algorithm>
 namespace Cubed {
 
-Slider::Slider(Widget* parent) : Widget(parent) {}
+Slider::Slider(Widget* parent) : Widget(parent) {
+    init_thumb();
+    init_track();
+}
 
 Slider& Slider::set_slider(float* value, const float& min, const float& max) {
     m_value = value;
@@ -15,20 +18,27 @@ Slider& Slider::set_slider(float* value, const float& min, const float& max) {
     return *this;
 }
 
-Image& Slider::set_track() {
+Image& Slider::get_track() { return *m_track; }
+Image& Slider::get_thumb() { return *m_thumb; }
+
+void Slider::init_track() {
     m_track = std::make_unique<Image>(this);
+
     m_track->set_fill(true);
+
     m_track->set_anchor(Anchor::TOP_LEFT);
-    return *m_track;
 }
 
-Image& Slider::set_thumb() {
+void Slider::init_thumb() {
     m_thumb = std::make_unique<Image>(this);
+
     m_thumb->set_height(height());
-    m_thumb->set_width(10.0f);
+
+    m_thumb->set_width(THUMB_WIDTH);
+
     m_thumb->set_anchor(Anchor::TOP_LEFT);
+
     m_thumb->set_scale(m_scale);
-    return *m_thumb;
 }
 
 float Slider::width() const { return m_width * m_scale; }
@@ -43,6 +53,8 @@ Slider& Slider::set_scale(float scale) {
 
 Slider& Slider::set_width(float width) {
     if (!m_thumb || width < m_thumb->width()) {
+        Logger::error("Width is too small set failed!");
+        ASSERT(false);
         return *this;
     }
     m_width = width;
@@ -51,9 +63,8 @@ Slider& Slider::set_width(float width) {
 
 Slider& Slider::set_height(float h) {
     m_height = h;
-    if (m_thumb) {
-        m_thumb->set_height(height());
-    }
+    ASSERT_MSG(m_thumb, "Thumb is nullptr !");
+    m_thumb->set_height(height());
     return *this;
 }